feat(mailnotice): notify customers of delayed mails per provider #19

Merged
fabrice.kirchner merged 1 commit from feat/mail-delay-notice into main 2026-11-21 13:04:43 +01:00
Owner

While a mail provider throttles our mails, only the affected customers
should see a notice. The notice appears next to the e-mail field on
registration, checkout, forgotten password and newsletter, and under
the heading of the order confirmation, and only for the providers
configured in the template settings. It is off by default, so the
shops sharing this template stay unchanged.

Background: since 15.11.2026 Microsoft defers mails of the shop
environment with 451 4.7.650 for its consumer domains. On 21.11.2026
all 42 mails in the queue went to hotmail, outlook and live, the oldest
after 116 hours. See fabrice.kirchner/k3s-prod#914.

  • template.xml: section mailnotice with switch, domains and two texts
  • layout/header.tpl: markup, text and domains as a template element
  • js/custom.js: checks the address and sets or removes the notice
  • checkout/order_completed.tpl: anchor of the order confirmation
  • README.md: how it is switched and which files take part

Effects: no change in a shop until the notice is switched on in the
template settings, and the defaults from template.xml reach
ttemplateeinstellungen only when those settings are saved once. The
domain check lives in the script only, so no notice without JavaScript.
Switching it off again is a setting, not a release.

Tests: the branch was deployed into cdp-testshop (files in the pod,
settings in ttemplateeinstellungen, caches cleared) and verified there.
The template element is present in the HTML of /Registrieren (page type
10) and /Passwort-vergessen (14), with the configured text, and absent
on /Konto (4) and the start page. 22 checks of the script logic were run
with jsdom, the first of them against the real registration page of the
testshop: the notice appears for hotmail.de, hotmail.com, OUTLOOK.com,
live.de and msn.com, not for gmail.com, mail.hotmail.de, hotmailer.de or
an empty field; it sits behind the form group of the field and is removed
when the address is corrected; the login field does not trigger it; a
prefilled field gets it on load; the order confirmation anchor is filled
for an affected address only; without the template element and with an
empty domain list nothing happens. All passed. The repository has no test
suite, so the checks are not committed.

Not covered: checkout (page type 11) and order confirmation (33) in a
running shop, both of which need a session with a cart or a completed
order, and the english text of the two-language shop.

Next steps after the merge: tag v5-8-0-4 and raise TEMPLATE_REF for
cdp-webshop and engel-webshop, then switch the notice on per shop in the
backend.

While a mail provider throttles our mails, only the affected customers should see a notice. The notice appears next to the e-mail field on registration, checkout, forgotten password and newsletter, and under the heading of the order confirmation, and only for the providers configured in the template settings. It is off by default, so the shops sharing this template stay unchanged. Background: since 15.11.2026 Microsoft defers mails of the shop environment with 451 4.7.650 for its consumer domains. On 21.11.2026 all 42 mails in the queue went to hotmail, outlook and live, the oldest after 116 hours. See fabrice.kirchner/k3s-prod#914. - template.xml: section mailnotice with switch, domains and two texts - layout/header.tpl: markup, text and domains as a template element - js/custom.js: checks the address and sets or removes the notice - checkout/order_completed.tpl: anchor of the order confirmation - README.md: how it is switched and which files take part Effects: no change in a shop until the notice is switched on in the template settings, and the defaults from template.xml reach ttemplateeinstellungen only when those settings are saved once. The domain check lives in the script only, so no notice without JavaScript. Switching it off again is a setting, not a release. Tests: the branch was deployed into cdp-testshop (files in the pod, settings in ttemplateeinstellungen, caches cleared) and verified there. The template element is present in the HTML of /Registrieren (page type 10) and /Passwort-vergessen (14), with the configured text, and absent on /Konto (4) and the start page. 22 checks of the script logic were run with jsdom, the first of them against the real registration page of the testshop: the notice appears for hotmail.de, hotmail.com, OUTLOOK.com, live.de and msn.com, not for gmail.com, mail.hotmail.de, hotmailer.de or an empty field; it sits behind the form group of the field and is removed when the address is corrected; the login field does not trigger it; a prefilled field gets it on load; the order confirmation anchor is filled for an affected address only; without the template element and with an empty domain list nothing happens. All passed. The repository has no test suite, so the checks are not committed. Not covered: checkout (page type 11) and order confirmation (33) in a running shop, both of which need a session with a cart or a completed order, and the english text of the two-language shop. Next steps after the merge: tag v5-8-0-4 and raise TEMPLATE_REF for cdp-webshop and engel-webshop, then switch the notice on per shop in the backend.
feat(mailnotice): notify customers of delayed mails per provider
All checks were successful
Freeze Gate / freeze-gate (pull_request) Successful in 0s
a02f77bed2
While a mail provider throttles our mails, only the affected customers
should see a notice. The notice appears next to the e-mail field on
registration, checkout, forgotten password and newsletter, and under
the heading of the order confirmation, and only for the providers
configured in the template settings. It is off by default, so the shops
sharing this template stay unchanged.

- template.xml: section mailnotice with switch, domains and two texts
- layout/header.tpl: markup, text and domains as a template element
- js/custom.js: checks the address and sets or removes the notice
- checkout/order_completed.tpl: anchor of the order confirmation
- README.md: how it is switched and which files take part
fabrice.kirchner deleted branch feat/mail-delay-notice 2026-11-21 13:04:43 +01:00
Author
Owner

Nach dem Merge geprüft (21.11.2026):

  • Merge-Commit 19b2d3e steckt in main, Remote-Branch gelöscht, Worktree und lokaler Branch aufgeräumt.
  • CI auf main: pre-commit (Lauf 444) grün, Renovate (445) grün. Freeze-Gate des PR war nach dem Label freeze/ok grün (Läufe 442 und 443), der rote Lauf 441 davor ist der erwartete Zustand ohne Label.
  • cdp-testshop trägt den gemergten Stand: die vier Dateien im Pod sind prüfsummengleich mit main. Der Testshop folgt TEMPLATE_BRANCH: main und zieht ihn beim nächsten Init-Lauf ohnehin erneut.
  • cdp-webshop und engel-webshop bleiben auf TEMPLATE_REF: v5-8-0-3 und sind damit unverändert, wie beabsichtigt.

Offen bleibt wie im PR-Text beschrieben: Bestellvorgang (Seitentyp 11) und Bestellabschluss (33) im laufenden Shop sowie der englische Text. Beides lässt sich mit einer Testbestellung im Testshop belegen; Mails gehen dort durch die NetworkPolicy deny-smtp-egress nicht hinaus.

Nächste Schritte: Tag v5-8-0-4 und danach TEMPLATE_REF in fabrice.kirchner/k3s-prod für beide Produktivshops, dann je Shop im Backend einschalten.

Nach dem Merge geprüft (21.11.2026): - Merge-Commit `19b2d3e` steckt in `main`, Remote-Branch gelöscht, Worktree und lokaler Branch aufgeräumt. - CI auf `main`: pre-commit (Lauf 444) grün, Renovate (445) grün. Freeze-Gate des PR war nach dem Label `freeze/ok` grün (Läufe 442 und 443), der rote Lauf 441 davor ist der erwartete Zustand ohne Label. - `cdp-testshop` trägt den gemergten Stand: die vier Dateien im Pod sind prüfsummengleich mit `main`. Der Testshop folgt `TEMPLATE_BRANCH: main` und zieht ihn beim nächsten Init-Lauf ohnehin erneut. - `cdp-webshop` und `engel-webshop` bleiben auf `TEMPLATE_REF: v5-8-0-3` und sind damit unverändert, wie beabsichtigt. Offen bleibt wie im PR-Text beschrieben: Bestellvorgang (Seitentyp 11) und Bestellabschluss (33) im laufenden Shop sowie der englische Text. Beides lässt sich mit einer Testbestellung im Testshop belegen; Mails gehen dort durch die NetworkPolicy `deny-smtp-egress` nicht hinaus. Nächste Schritte: Tag `v5-8-0-4` und danach `TEMPLATE_REF` in `fabrice.kirchner/k3s-prod` für beide Produktivshops, dann je Shop im Backend einschalten.
Sign in to join this conversation.
No description provided.