feat(mailnotice): notify customers of delayed mails per provider #19
No reviewers
Labels
No labels
blocked/freeze
follow-up
freeze/ok
help-wanted
kind
bug
kind
change
kind
debt
kind
diagnosis
kind
docs
kind
feature
kind
question
kind
watch
no-test-needed
resolution
duplicate
resolution
invalid
resolution
wontfix
triage
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
fabrice.kirchner/jtl-shop-novachild!19
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/mail-delay-notice"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
While a mail provider throttles our mails, only the affected customers
should see a notice. The notice appears next to the e-mail field on
registration, checkout, forgotten password and newsletter, and under
the heading of the order confirmation, and only for the providers
configured in the template settings. It is off by default, so the
shops sharing this template stay unchanged.
Background: since 15.11.2026 Microsoft defers mails of the shop
environment with 451 4.7.650 for its consumer domains. On 21.11.2026
all 42 mails in the queue went to hotmail, outlook and live, the oldest
after 116 hours. See fabrice.kirchner/k3s-prod#914.
Effects: no change in a shop until the notice is switched on in the
template settings, and the defaults from template.xml reach
ttemplateeinstellungen only when those settings are saved once. The
domain check lives in the script only, so no notice without JavaScript.
Switching it off again is a setting, not a release.
Tests: the branch was deployed into cdp-testshop (files in the pod,
settings in ttemplateeinstellungen, caches cleared) and verified there.
The template element is present in the HTML of /Registrieren (page type
10) and /Passwort-vergessen (14), with the configured text, and absent
on /Konto (4) and the start page. 22 checks of the script logic were run
with jsdom, the first of them against the real registration page of the
testshop: the notice appears for hotmail.de, hotmail.com, OUTLOOK.com,
live.de and msn.com, not for gmail.com, mail.hotmail.de, hotmailer.de or
an empty field; it sits behind the form group of the field and is removed
when the address is corrected; the login field does not trigger it; a
prefilled field gets it on load; the order confirmation anchor is filled
for an affected address only; without the template element and with an
empty domain list nothing happens. All passed. The repository has no test
suite, so the checks are not committed.
Not covered: checkout (page type 11) and order confirmation (33) in a
running shop, both of which need a session with a cart or a completed
order, and the english text of the two-language shop.
Next steps after the merge: tag v5-8-0-4 and raise TEMPLATE_REF for
cdp-webshop and engel-webshop, then switch the notice on per shop in the
backend.
Nach dem Merge geprüft (21.11.2026):
19b2d3esteckt inmain, Remote-Branch gelöscht, Worktree und lokaler Branch aufgeräumt.main: pre-commit (Lauf 444) grün, Renovate (445) grün. Freeze-Gate des PR war nach dem Labelfreeze/okgrün (Läufe 442 und 443), der rote Lauf 441 davor ist der erwartete Zustand ohne Label.cdp-testshopträgt den gemergten Stand: die vier Dateien im Pod sind prüfsummengleich mitmain. Der Testshop folgtTEMPLATE_BRANCH: mainund zieht ihn beim nächsten Init-Lauf ohnehin erneut.cdp-webshopundengel-webshopbleiben aufTEMPLATE_REF: v5-8-0-3und sind damit unverändert, wie beabsichtigt.Offen bleibt wie im PR-Text beschrieben: Bestellvorgang (Seitentyp 11) und Bestellabschluss (33) im laufenden Shop sowie der englische Text. Beides lässt sich mit einer Testbestellung im Testshop belegen; Mails gehen dort durch die NetworkPolicy
deny-smtp-egressnicht hinaus.Nächste Schritte: Tag
v5-8-0-4und danachTEMPLATE_REFinfabrice.kirchner/k3s-prodfür beide Produktivshops, dann je Shop im Backend einschalten.